Adding Live Templates #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user wants to define a new spec, they can:
1. Create a **Kotlin file** (Not class) in the desired location, with the name of the spec they want to define.
2. In the opened file, use one of the provided live templates. For instance `fspec` to start defining a FunSpec
`fspec` expands into:
```kotlin
class MyTest : FunSpec({
test("Foo") {
1 shouldBe 1
}
}
```
Where `MyTest` is based on the name of the file, and is the first focused location which lets the user change the Spec name if desired. Pressing tab moves the focus to the name of the test (`Foo`). The user can change the name then press tab again to focus the test body.
IntelliJ also added an import for FunSpec automatically.
Desired feedback:
---
What spec styles and abbreviations should we use?
So far I have added:
* `sspec` -> StringSpec
* Perhaps FreeSpec is a better spec to focus on, given that it supports nesting. But I think we might harmonize them and settle on a final name for this style
* `bspec` -> BehaviorSpec
* `fspec` -> FunSpec
* This one clashes a bit with FreeSpec and FeatureSpec
|
could also just have |
|
Do we want to merge this in @Kantis ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user wants to define a new spec, they can:
fspecto start defining a FunSpecfspecexpands into:Where
MyTestis based on the name of the file, and is the first focused location which lets the user change the Spec name if desired. Pressing tab moves the focus to the name of the test (Foo). The user can change the name then press tab again to focus the test body.IntelliJ also added an import for FunSpec automatically.
Desired feedback:
What spec styles and abbreviations should we use?
So far I have added:
sspec-> StringSpecbspec-> BehaviorSpecfspec-> FunSpecMaybe we can dogfood this one in the wild.. not a lot of users would find the feature w/o us advertising it somewhere.